Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manuscripta bf2 form #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Manuscripta bf2 form #1

wants to merge 4 commits into from

Conversation

klngwll
Copy link
Contributor

@klngwll klngwll commented Dec 21, 2021

Redan ändrat:

  • instanceOf.[Type] = Text
  • länkar till id.kb.se istället för id.loc.gov

I PR

  • descriptionCreator blir automatiskt skapande sigel. Ny form behövs för att uttrycka informationen nedan:
"descriptionCreator": [
  {
    "@type": "Person",
    "name": "Patrik Åström",
    "marc:relatedAs": {
      "role": [
        {
          "@id": "https://id.kb.se/relator/dtm"
        }
      ]
    }
  },
  {
    "@type": "Person",
    "name": "Patrik Granholm",
    "marc:relatedAs": {
      "role": [
        {
          "@id": "https://id.kb.se/relator/dtm"
        }
      ]
    }
  }
]

@klngwll
Remove descriptionCreator
3a7eeca 
Set automatically to sigel
@klngwll klngwll requested review from olovy, niklasl and kwahlin December 21, 2021 07:59
niklasl
niklasl reviewed Dec 21, 2021
View reviewed changes
sketches/bibliographic/manuscripta_example_100201.jsonld
{
"@type": "Person",
"name": "Patrik Åström",
"marc:relatedAs": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Räcker med en länk till personerna? D.v.s. ta bort marc:relatedAs här. Rollen är ju redundant få personen de facto är "data manager" då den skapar/redigerar metadata-poster (eller om man vill ange den som "yrke" på agenten orelaterat till att personen).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasl niklasl niklasl left review comments

@olovy olovy Awaiting requested review from olovy

@kwahlin kwahlin Awaiting requested review from kwahlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klngwll @niklasl